git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fwd: Fwd: git-daemon access-hook race condition

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 12, 2013, 23:27 UTC
Message-ID
<xmqqppsdmxig.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAPZPVFYY6Q=zZ62mY6uGi6O7KaOO8NhUEH0YUgcQE3NBvHQEpg@mail.gmail.com>
Eugene Sajine <euguess@gmail.com> writes:
Show 16 quoted lines
>> So even if we feed the exit status of the service process to the
>> hook script specified by the --post-service-hook, it does not tell
>> the script if the service "succeeded" in that sense.
>
> I see what you're saying.
> In my particular use case I can work around that service status
> because even if it failed it will just trigger Jenkins to poll and in
> case of failure to transfer data there will be no new changes for
> Jenkins to work with. If we would want the --post-service-hook to know
> that data transfer succeeded or failed, then may be there should be
> some difference between "service status" and "service process status"?
> In this case the existing logic works with "service process status"
> while the --post-service-hook is fed with the "service status" (or
> name it "data transfer status")
>
> Do i make any sense?

Almost; you missed that there is no channel to pass "data transfer status" from the service back to the daemon.

Previous: Eugene Sajine
Message 10 of 10 in “Fwd: git-daemon access-hook race condition”
  1. Eugene SajineSep 12, 2013
  2. Junio C HamanoSep 12, 2013
  3. Fwd: Fwd: git-daemon access-hook race conditionEugene Sajine, Sep 12, 2013
  4. Junio C HamanoSep 12, 2013
  5. Eugene SajineSep 12, 2013
  6. Eugene SajineSep 12, 2013
  7. Eugene SajineSep 13, 2013
  8. Junio C HamanoSep 12, 2013
  9. Eugene SajineSep 12, 2013
  10. Junio C HamanoSep 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.