Fwd: Fwd: git-daemon access-hook race condition

From: Eugene Sajine <euguess@gmail.com>
Date: Sep 12, 2013, 20:30 UTC
Message-ID: <CAPZPVFZpYJnQY4BpjaPxU8NnBmPZ9Fp6UpovoQEvkKzRnLa=KA@mail.gmail.com>
In-Reply-To: <CAPZPVFZLPV=JVR+SSqfX-=aLyFWZBkof+yCkivcLoKNnv6f__Q@mail.gmail.com>

On Thu, Sep 12, 2013 at 3:15 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Eugene Sajine <euguess@gmail.com> writes:
>
>> Is it possible to have access-hook to be executed after receive?
>
> The whole point of access-hook is to allow it to decide whether the
> access is allowed or not, so that is a non-starter.
>
> A notification _after_ successful push update is usually done via
> the post-receive hook in the receiving repository, I think.

Junio,

Thanks for the reply!

This is interesting: i always thought about the access-hook as something to be executed when the repo is accessed, not just verification if access is allowed - your definition is much more limiting.

we have about 1400 bare repos - so i would like to avoid the configuration of each one of them. I could probably find a way to automate it, but already having access-hook in current implementation makes me reluctant to go this way, because it is so much easier to use centralized manager.

So are you really sure that it is a non-starter to have --before-service/--after-service options for access-hook?

Thanks, Eugene