git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] commit.c: check for lock error and return early

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 17, 2014, 21:09 UTC
Message-ID
<xmqqppkfd5ov.fsf@gitster.dls.corp.google.com>
In-Reply-To
<534EFEE0.9000806@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 10 quoted lines
> On 04/16/2014 08:56 PM, Ronnie Sahlberg wrote:
>> Move the check for the lock failure to happen immediately after
>> lock_any_ref_for_update().
>> Previously the lock and the check-if-lock-failed was separated by a handful
>> of string manipulation statements.
>
> Please flow sentences together into paragraphs for easier reading,
> rather than having an extremely ragged right-hand margin.
>
> The rest looks good.

Thanks, both. I tentatively queued with the suggested log message tweaks, and I think result reads better.

Previous: Michael Haggerty
Message 6 of 6 in “Check for lock failures early”
  1. 0/2 Check for lock failures earlyRonnie Sahlberg, Apr 16, 2014
  2. 1/2 sequencer.c: check for lock failure and bail early in fast_forward_toRonnie Sahlberg, Apr 16, 2014
  3. Michael HaggertyApr 16, 2014
  4. 2/2 commit.c: check for lock error and return earlyRonnie Sahlberg, Apr 16, 2014
  5. Michael HaggertyApr 16, 2014
  6. Junio C HamanoApr 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.