From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 17 Apr 2014 21:09:04 GMT
Subject: Re: [PATCH v2 2/2] commit.c: check for lock error and return early
Message-ID: <xmqqppkfd5ov.fsf@gitster.dls.corp.google.com>
In-Reply-To: <534EFEE0.9000806@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> On 04/16/2014 08:56 PM, Ronnie Sahlberg wrote:
>> Move the check for the lock failure to happen immediately after
>> lock_any_ref_for_update().
>> Previously the lock and the check-if-lock-failed was separated by a handful
>> of string manipulation statements.
>
> Please flow sentences together into paragraphs for easier reading,
> rather than having an extremely ragged right-hand margin.
>
> The rest looks good.

Thanks, both.  I tentatively queued with the suggested log message
tweaks, and I think result reads better.