git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] git-p4: fix handling of multi-word P4EDITOR

From
Junio C Hamano <gitster@pobox.com>
Date
May 26, 2015, 20:21 UTC
Message-ID
<xmqqpp5njdjm.fsf@gitster.dls.corp.google.com>
In-Reply-To
<556199A2.8090802@diamand.org>
Luke Diamand <luke@diamand.org> writes:
Show 14 quoted lines
> On 07/05/15 23:16, Junio C Hamano wrote:
>> Luke Diamand <luke@diamand.org> writes:
>>
>
> [Resurrecting old thread]
> ...
>
> To me, that seems to imply that for GIT_WINDOWS_NATIVE, we take the
> *second* branch and use "sh", so again, the the code as it stands will
> be fine. msysgit uses that path.
> ...
>
> I don't think we need to do anything. msysgit works fine with the
> origin "sh", "-c", ... code.
Thanks.  Let's merge what is in 'pu' down to 'next' then.
Previous: Luke Diamand
Message 13 of 13 in “Re: Bug: git-p4 edit_template() and P4EDITOR w/options”
  1. 0/2 Re: Bug: git-p4 edit_template() and P4EDITOR w/optionsLuke Diamand, May 7, 2015
  2. 1/2 git-p4: add failing test for P4EDITOR handlingLuke Diamand, May 7, 2015
  3. 2/2 git-p4: fix handling of multi-word P4EDITORLuke Diamand, May 7, 2015
  4. Junio C HamanoMay 7, 2015
  5. Luke DiamandMay 7, 2015
  6. Junio C HamanoMay 7, 2015
  7. Luke DiamandMay 7, 2015
  8. Junio C HamanoMay 7, 2015
  9. Junio C HamanoMay 7, 2015
  10. Luke DiamandMay 7, 2015
  11. Junio C HamanoMay 7, 2015
  12. Luke DiamandMay 24, 2015
  13. Junio C HamanoMay 26, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.