Re: [PATCH 2/2] git-p4: fix handling of multi-word P4EDITOR

From: Luke Diamand <luke@diamand.org>
Date: May 7, 2015, 20:42 UTC
Message-ID: <554BCE25.5070308@diamand.org>
In-Reply-To: <xmqqlhh0nny1.fsf@gitster.dls.corp.google.com>

On 07/05/15 21:16, Junio C Hamano wrote:

Show 16 quoted lines

> Luke Diamand <luke@diamand.org> writes:
>
>> On Linux:
>>
>> $ export P4EDITOR="gvim -f"
>> $ p4 submit
>> -- works as you would hope --
>>
>> $ export P4EDITOR="/home/lgd/My Programs/editor.sh"
>> $ p4 submit
>> sh: 1: /home/lgd/My: not found
>>
>> $ export P4EDITOR="/home/lgd/My\ Programs/editor.sh"
>> -- works fine --
>
> Good.  That is exactly I wanted to see.

Test case t9805-git-p4-skip-submit-edit.sh fails with that change. It sets P4EDITOR to "$TRASH_DIRECTORY/ed.sh".