git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/5] index-pack: Use the new worker pool

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 25, 2015, 22:50 UTC
Message-ID
<xmqqpp2bvv87.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CAGZ79kaMeaTiQgVxjf5aPAtLVw224Hf9gzDNS85+9C+rj_keWA@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
> Then please don't pick up this patch. This and patch 5 are there to convince
> Jeff this is a good API, worth being introduced and not over engineered, just
> solving a problem we're interested in with a minimal amount of code to side
> track from the actual goal we want to pursue.

Don't worry. I did not have intention to queue index-pack and pack-objects rewrite unless the use of the new API makes them demonstratably better.

The criteria for "worth being introduced" would include "not excessively heavyweight", I would think. And it was good that we have these two patches to judge if the earlier one (2-3/5) is a good thing to add in a concrete way. Perhaps the 2% slowdown might be showing the performance characteristics of your worker pool model, and Peff's suggestion to at least see (if not solve) where the overhead is coming from was a very reasonable one, I would think.

Previous: Stefan BellerNext: Stefan Beller
Message 18 of 19 in “Demonstrate new parallel threading API”
  1. 0/5 Demonstrate new parallel threading APIStefan Beller, Aug 25, 2015
  2. 1/5 FIXUP submodule: implement `module_clone` as a builtin helperStefan Beller, Aug 25, 2015
  3. 2/5 thread-utils: add a threaded task queueStefan Beller, Aug 25, 2015
  4. 3/5 submodule: helper to run foreach in parallelStefan Beller, Aug 25, 2015
  5. Junio C HamanoAug 25, 2015
  6. Stefan BellerAug 25, 2015
  7. Junio C HamanoAug 25, 2015
  8. Junio C HamanoAug 25, 2015
  9. Jeff KingAug 26, 2015
  10. Stefan BellerAug 26, 2015
  11. 4/5 index-pack: Use the new worker poolStefan Beller, Aug 25, 2015
  12. Jeff KingAug 25, 2015
  13. Stefan BellerAug 25, 2015
  14. Junio C HamanoAug 25, 2015
  15. Stefan BellerAug 25, 2015
  16. Junio C HamanoAug 25, 2015
  17. Stefan BellerAug 25, 2015
  18. Junio C HamanoAug 25, 2015
  19. 5/5 pack-objects: Use new worker poolStefan Beller, Aug 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.