git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/5] index-pack: Use the new worker pool

From
Stefan Beller <sbeller@google.com>
Date
Aug 25, 2015, 22:39 UTC
Message-ID
<CAGZ79kaMeaTiQgVxjf5aPAtLVw224Hf9gzDNS85+9C+rj_keWA@mail.gmail.com>
In-Reply-To
<xmqq37z7xebe.fsf@gitster.dls.corp.google.com>
On Tue, Aug 25, 2015 at 2:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> Not sure I follow there.
>>
>> Original implementation:
>> We have M threads sitting around the table, all of them trying to obtain food
>> from the one bowl on the table and then eating it.
>> Once the bowl is all eaten, we can stop.
>>
>> New pattern:
>> One cook puts all the food items on the sushi-go-round-belt with a fancy plate
>> and the threads grab them one by one still using locks (but they are internal to
>> the belt).
>>
>> Are you saying we're content with just a bowl and everyone helps themselves
>> for getting food?
>
> No.  I am questioning how big overhead is for having the
> go-round-belt that must hold all dishes to be eaten, which did not
> exist in the original arrangement.
>
>

Then please don't pick up this patch. This and patch 5 are there to convince Jeff this is a good API, worth being introduced and not over engineered, just solving a problem we're interested in with a minimal amount of code to side track from the actual goal we want to pursue.

Previous: Junio C HamanoNext: Junio C Hamano
Message 17 of 19 in “Demonstrate new parallel threading API”
  1. 0/5 Demonstrate new parallel threading APIStefan Beller, Aug 25, 2015
  2. 1/5 FIXUP submodule: implement `module_clone` as a builtin helperStefan Beller, Aug 25, 2015
  3. 2/5 thread-utils: add a threaded task queueStefan Beller, Aug 25, 2015
  4. 3/5 submodule: helper to run foreach in parallelStefan Beller, Aug 25, 2015
  5. Junio C HamanoAug 25, 2015
  6. Stefan BellerAug 25, 2015
  7. Junio C HamanoAug 25, 2015
  8. Junio C HamanoAug 25, 2015
  9. Jeff KingAug 26, 2015
  10. Stefan BellerAug 26, 2015
  11. 4/5 index-pack: Use the new worker poolStefan Beller, Aug 25, 2015
  12. Jeff KingAug 25, 2015
  13. Stefan BellerAug 25, 2015
  14. Junio C HamanoAug 25, 2015
  15. Stefan BellerAug 25, 2015
  16. Junio C HamanoAug 25, 2015
  17. Stefan BellerAug 25, 2015
  18. Junio C HamanoAug 25, 2015
  19. 5/5 pack-objects: Use new worker poolStefan Beller, Aug 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.