Re: [PATCH] pass transport verbosity down to git_connect

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 29, 2016, 03:19 UTC
Message-ID: <xmqqpowljcn1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160129003816.GA26200@dcvr.yhbt.net>

Eric Wong <normalperson@yhbt.net> writes:

> On the other hand, I'm not sure if there's anything parsing the stderr
> out of "git fetch -v" right now.

It would also affect end-user experience, depending on what new pieces of lines are emitted to the terminal. From "git fetch -v", I expect to see the transfer progress and the final listing of fetched and updated refs, and as long as the line "remote: Compressing objects" and the lines that follow do not get garbled, I would imagine it would be fine.

  ...
  remote: Compressing objects: 100% (1195/1195), done.
  remote: Total 1869 (delta 1551), reused 841 (delta 672)
  Receiving objects: 100% (1869/1869), 462.80 KiB | 0 bytes/s, done.
  Resolving deltas: 100% (1551/1551), completed with 335 local objects.
  From $over_there
   * branch            pu         -> FETCH_HEAD

>  In that case, perhaps only changing
> "-vv" (and documenting it) is a better idea.

I just reviewed the output that are protected by CONNECT_VERBOSE; they look somewhere between pure debugging aid (like the protocol dump that are shown by "fetch -vv") and progress display, and at least to me they are much closer to the latter than the former, in the sense that they are not _so_ annoying as the protocol dump that are clearly not meant for the end users, and that they say "I am looking up this host's address", "Now connecting to this host:port", etc.

So, I personally find this addtional output not _too_ bad if we give it with "fetch -v" (not limiting to "fetch -vv").

I dunno.