Re: [PATCH] pass transport verbosity down to git_connect

From: Jeff King <peff@peff.net>
Date: Jan 29, 2016, 03:47 UTC
Message-ID: <20160129034748.GA21125@sigill.intra.peff.net>
In-Reply-To: <xmqqpowljcn1.fsf@gitster.mtv.corp.google.com>

On Thu, Jan 28, 2016 at 07:19:30PM -0800, Junio C Hamano wrote:

Show 11 quoted lines

> I just reviewed the output that are protected by CONNECT_VERBOSE;
> they look somewhere between pure debugging aid (like the protocol
> dump that are shown by "fetch -vv") and progress display, and at
> least to me they are much closer to the latter than the former, in
> the sense that they are not _so_ annoying as the protocol dump that
> are clearly not meant for the end users, and that they say "I am
> looking up this host's address", "Now connecting to this host:port",
> etc.
> 
> So, I personally find this addtional output not _too_ bad if we give
> it with "fetch -v" (not limiting to "fetch -vv").

Yeah, I do not feel that strongly, and am OK if it is attached to a single "-v". I don't think we make any promises about scraping stderr, so it is really just about end-user experience. It is mostly just my gut feeling on what I'd expect based on other parts of git (especially "fetch -vv" in other circumstances).

-Peff