Re: [PATCH v2 00/13] Reference iterators

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2016, 21:33 UTC
Message-ID: <xmqqporyneik.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <cover.1464957077.git.mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> This patch series applies on top of mh/split-under-lock. It can also
> be obtained from my GitHub repo [2] as branch "ref-iterators".

Ah, that reminds me.  What's the doneness of the dependent topic?

The patches in this series looked all good to me.

Show 37 quoted lines

> Michael
>
> [1] http://thread.gmane.org/gmane.comp.version-control.git/295860
> [2] https://github.com/mhagger/git
>
> Michael Haggerty (13):
>   refs: remove unnecessary "extern" keywords
>   do_for_each_ref(): move docstring to the header file
>   refs: use name "prefix" consistently
>   delete_refs(): add a flags argument
>   remote rm: handle symbolic refs correctly
>   get_ref_cache(): only create an instance if there is a submodule
>   entry_resolves_to_object(): rename function from
>     ref_resolves_to_object()
>   ref_resolves_to_object(): new function
>   refs: introduce an iterator interface
>   do_for_each_ref(): reimplement using reference iteration
>   for_each_reflog(): don't abort for bad references
>   dir_iterator: new API for iterating over a directory tree
>   for_each_reflog(): reimplement using iterators
>
>  Makefile             |   2 +
>  builtin/fetch.c      |   2 +-
>  builtin/remote.c     |   8 +-
>  dir-iterator.c       | 185 +++++++++++++++
>  dir-iterator.h       |  86 +++++++
>  iterator.h           |  81 +++++++
>  refs.c               |  20 ++
>  refs.h               | 139 +++++++-----
>  refs/files-backend.c | 629 +++++++++++++++++++++++++++++++--------------------
>  refs/iterator.c      | 384 +++++++++++++++++++++++++++++++
>  refs/refs-internal.h | 226 +++++++++++++++++-
>  11 files changed, 1440 insertions(+), 322 deletions(-)
>  create mode 100644 dir-iterator.c
>  create mode 100644 dir-iterator.h
>  create mode 100644 iterator.h
>  create mode 100644 refs/iterator.c