Re: get_maintainer.pl and .mailmap entries with more than 2 addresses

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 2, 2016, 18:16 UTC
Message-ID: <xmqqpoprdojp.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1470155781.3998.181.camel@perches.com>

Joe Perches <joe@perches.com> writes:

Show 11 quoted lines

> Hello Florian.
>
> There is at least an oddity with get_maintainer handling of a
> .mailmap entry form.
>
> For instance:
>
> Mauro's .mailmap entry is:
> Mauro Carvalho Chehab <mchehab@kernel.org> <maurochehab@gmail.com> <mchehab@infradead.org> <mchehab@redhat.com> <m.chehab@samsung.com> <mchehab@osg.samsung.com> <mchehab@s-opensource.com>
>
> Is this a valid form?

I do not think so, according to "git shortlog --help" (the canonical source of the document is Documentation/mailmap.txt, but shortlog doc includes it). Here is the relevant bits.

    In the simple form, each line in the file consists of the canonical
    real name of an author, whitespace, and an email address used in the
    commit (enclosed by '<' and '>') to map to the name. For example:
    --
            Proper Name <commit@email.xx>
    --

    The more complex forms are:
    --
            <proper@email.xx> <commit@email.xx>
    --
    which allows mailmap to replace only the email part of a commit, and:
    --
            Proper Name <proper@email.xx> <commit@email.xx>
    --
    which allows mailmap to replace both the name and the email of a
    commit matching the specified commit email address, and:
    --
            Proper Name <proper@email.xx> Commit Name <commit@email.xx>
    --
    which allows mailmap to replace both the name and the email of a
    commit matching both the specified commit name and email address.