Re: get_maintainer.pl and .mailmap entries with more than 2 addresses

From: Joe Perches <joe@perches.com>
Date: Aug 2, 2016, 22:26 UTC
Message-ID: <1470176777.3998.203.camel@perches.com>
In-Reply-To: <6A56763C-D795-4943-AFE9-8A53ECD61AF6@mickler.org>

On Wed, 2016-08-03 at 00:17 +0200, Florian Mickler wrote:

Show 56 quoted lines

> cc'd mchehab@s-opensource.com  (Mauro, is your kernel.org address up?)
> 
>  Am Tue, 02 Aug 2016 09:36:21 -0700
> schrieb Joe Perches <joe@perches.com>:
> 
> > 
> > Hello Florian.
> > There is at least an oddity with get_maintainer handling of a
> > .mailmap entry form.
> > 
> > For instance:
> > 
> > Mauro's .mailmap entry is:
> > Mauro Carvalho Chehab <mchehab@kernel.org> <maurochehab@gmail.com>
> > <mchehab@infradead.org> <mchehab@redhat.com> <m.chehab@samsung.com>
> > <mchehab@osg.samsung.com> <mchehab@s-opensource.com>
> > 
> > Is this a valid form?
> > 
> > get_maintainer output for Mauro is:
> > 
> > $ ./scripts/get_maintainer.pl drivers/media/ -f
> > Mauro Carvalho Chehab <mchehab@kernel.org> <maurochehab@gmail.com>
> > <mchehab@infradead.org> <mchehab@redhat.com> <m.chehab@samsung.com>
> > <mchehab@osg.samsung.com> (maintainer:MEDIA INPUT INFRASTRUCTURE
> > (V4L/DVB))
> > 
> > I believe the Mauro's and Shuah's .mailmap entries are improper and
> > should be changed, but I'm not completely aware of git .mailmap
> > handling and the documentation seems weakly specified.
> > 
> Hmm.. looking at Mauros last .mailmap commit it seems like your patch is
> ok for Mauro. 
> 
> Although <mywing81@gmail.com> and <mchehab@brturbo.com.br> are probably
> missing? (@Mauro) 
> 
> 
> $ git shortlog | grep "^Mauro C"
> Mauro Carvalho Chehab (4404):
> $ git log | grep "^Author:.*Mauro Carvalho Chehab" | sort | uniq -c
>       2 Author: Mauro Carvalho Chehab <maurochehab@gmail.com>
>     146 Author: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
>     645 Author: Mauro Carvalho Chehab <mchehab@infradead.org>
>     794 Author: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>    2015 Author: Mauro Carvalho Chehab <mchehab@redhat.com>
>     448 Author: Mauro Carvalho Chehab <m.chehab@samsung.com>
>     353 Author: Mauro Carvalho Chehab <mchehab@s-opensource.com>
>       1 Author: Mauro Carvalho Chehab <mywing81@gmail.com>
> 
> 
> 
> Anyway, from a technical viewpoint your patches seem to fix
> the .mailmap entry as the author intended. (See Junio's Email for the
> documantation part) 
> But I would wait for the ack from Mauro and Shuah.

As far as I understand, a single entry with just their name and preferred email address would work too because the name parts are all spelled identically.