Re: [PATCH v2] upload-pack: Optionally allow fetching any sha1

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 13, 2016, 01:23 UTC
Message-ID: <xmqqpom0yxyo.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1478885028-30357-1-git-send-email-dturner@twosigma.com>

David Turner <dturner@twosigma.com> writes:

> diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh
> index 43665ab..8d3db40 100755

It seems that I haven't heard of 43665ab.

Show 5 quoted lines

> --- a/t/t5551-http-fetch-smart.sh
> +++ b/t/t5551-http-fetch-smart.sh
> @@ -306,6 +306,28 @@ test_expect_success 'test allowreachablesha1inwant with unreachable' '
>  	test_must_fail git -C test_reachable.git fetch origin "$(git rev-parse HEAD)"
>  '

Specifically, the above seems to be missing in my tree.

Perhaps you noticed the lack of test for allowReachableSHA1InWant and added one, but forgot to send it out, while building this patch on top?

> +uploadpack.allowAnySHA1InWant::
> +	Allow `upload-pack` to accept a fetch request that asks for any
> +	object at all.
> +	Defaults to `false`.