RE: [PATCH v2] upload-pack: Optionally allow fetching any sha1
- From
- David Turner <david.turner@twosigma.com>
- Date
- Nov 14, 2016, 16:02 UTC
- Message-ID
- <5516d21568954cd5b18f0e56aa6f0ced@exmbdft7.ad.twosigma.com>
- In-Reply-To
- <xmqqpom0yxyo.fsf@gitster.mtv.corp.google.com>
Sorry about that -- the first version of this patch noted:
"""This one is on top of yesterday's patch, "remote-curl: don't hang when a server dies before any output".
That's because I want my test to show that allowanysha1inhead allows a fetch to succeed where allowreachablesha1inhead would fail. Prior to the previous patch, the first fetch's failure would instead be a hang.""""
But I didn't carry over this message to v2.
Show 31 quoted lines
> -----Original Message----- > From: Junio C Hamano [mailto:gitster@pobox.com] > Sent: Saturday, November 12, 2016 8:23 PM > To: David Turner > Cc: git@vger.kernel.org; spearce@spearce.org > Subject: Re: [PATCH v2] upload-pack: Optionally allow fetching any sha1 > > David Turner <dturner@twosigma.com> writes: > > > diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh > > index 43665ab..8d3db40 100755 > > It seems that I haven't heard of 43665ab. > > > --- a/t/t5551-http-fetch-smart.sh > > +++ b/t/t5551-http-fetch-smart.sh > > @@ -306,6 +306,28 @@ test_expect_success 'test allowreachablesha1inwant > with unreachable' ' > > test_must_fail git -C test_reachable.git fetch origin "$(git rev- > parse HEAD)" > > ' > > Specifically, the above seems to be missing in my tree. > > Perhaps you noticed the lack of test for allowReachableSHA1InWant and > added one, but forgot to send it out, while building this patch on top? > > > +uploadpack.allowAnySHA1InWant:: > > + Allow `upload-pack` to accept a fetch request that asks for any > > + object at all. > > + Defaults to `false`.