Re: [PATCH 0/5] extend git-describe pattern matching
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 13, 2017, 18:48 UTC
- Message-ID
- <xmqqpojqhk3i.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170112001721.2534-1-jacob.e.keller@intel.com>
Jacob Keller <jacob.e.keller@intel.com> writes:
Show 5 quoted lines
> From: Jacob Keller <jacob.keller@gmail.com> > > Teach git describe and git name-rev the ability to match multiple > patterns inclusively. Additionally, teach these commands to also accept > negative patterns to discard any refs which match.
You made quick responses to reviews with "will change", so I am not queuing this round to my tree; please don't mistake that as my indifference or opposition to the topic. This sounds like a good thing.
As to the semantics of mixing positives and negatives, I would recommend this to follow how positive and negative pathspecs mix. IIRC we chose to use the most simple and easy to explain option, i.e. a thing must match at least one of the positives and must not match any of the negatives to be considered a match.