Re: [PATCH 5/5] describe: teach describe negative pattern matches
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Jan 13, 2017, 06:57 UTC
- Message-ID
- <CA+P7+xq1LMkRG_aSyamrsPUQE+rDv4A9Qd19tDMgx-_a5OHsqQ@mail.gmail.com>
- In-Reply-To
- <5c8401ef-9609-f235-9228-be980a13edf1@kdbg.org>
On Thu, Jan 12, 2017 at 10:43 PM, Johannes Sixt <j6t@kdbg.org> wrote:
Show 25 quoted lines
> Am 13.01.2017 um 01:59 schrieb Jacob Keller: >> >> I think that --exclude makes sense, but the current implementation >> does not differentiate ordering, since both are merely accumulated >> into string_lists and then matched together. I'm not sure how order >> would impact things here? In the current implementation, if something >> is excluded and matched, it will be excluded. That is, exclusion >> patterns take precedence over match patterns. I think this makes the >> most sense semantically. > > > When you write > > git log --exclude=wip/* --branches --remotes > > --exclude applies only to --branches, not to --remotes. > > When you write > > git log --branches --exclude=origin/* --remotes > > --exclude=origin/* applies only to --remotes, but not to --branches. > > -- Hannes >
Well for describe I don't think the order matters.
Thanks, Jake