Re: [PATCH] connect: handle putty/plink also in GIT_SSH_COMMAND
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 25, 2017, 23:25 UTC
- Message-ID
- <xmqqpoja7mej.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170125224043.jxjc4avuy4ztnkm4@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 12 quoted lines
> On Wed, Jan 25, 2017 at 02:35:36PM -0800, Junio C Hamano wrote: > >> -- >8 -- >> Subject: [PATCH] connect: core.sshvariant to correct misidentification > > I have been watching this discussion from the sidelines, and I agree > that this direction is a big improvement. > ... > IIRC, the "const" in git_config_get_string_const is only about avoiding > an annoying cast. The result is still allocated and needs freed. Since > you are not keeping the value after the function returns, I think you > could just use git_config_get_value().
It is too late for today's pushout (I have this topic near the tip of 'pu', so it is possible to tweak and redo only 'pu' branch, but I generally hate tweaking things after 15:00 my time), but I'll fix that before the topic hits 'jch' (which is a bit more than 'next' and that is what I use for everyday work).
Thanks.