Re: [PATCH 09/29] grep: amend submodule recursion test for regex engine testing

From: Junio C Hamano <gitster@pobox.com>
Date: May 12, 2017, 04:59 UTC
Message-ID: <xmqqpofe7jrq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170511091829.5634-10-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 18 quoted lines

> Amend the submodule recursion test to prepare it for subsequent tests
> of whether it passes along the grep.patternType to the submodule
> greps.
>
> This is the result of searching & replacing:
>
>     foobar -> (1|2)d(3|4)
>     foo    -> (1|2)
>     bar    -> (3|4)
> ...
>  test_expect_success 'grep and multiple patterns' '
>  	cat >expect <<-\EOF &&
> -	b/b:bar
> +	b/b:(3|4)
>  	EOF
>  
> -	git grep -e "bar" --and --not -e "foo" --recurse-submodules >actual &&
> +	git grep -e "(3|4)" --and --not -e "(1|2)d" --recurse-submodules >actual &&

This breaks the promise "foo maps to (1|2)"; I do not think you need to add 'd' in order to make the test to succeed, so I am not sure what is going on here.