git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] usage: add NORETURN to BUG() function definitions

From
Junio C Hamano <gitster@pobox.com>
Date
May 23, 2017, 03:32 UTC
Message-ID
<xmqqpof0memv.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<15d73455-6d0e-e67a-7cf3-eb0ae9aa3b0d@ramsayjones.plus.com>
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
Show 31 quoted lines
> Having said that, I rarely run sparse over just one file (except
> when fixing a sparse error/warning). On each branch (master->next->pu)
> I do
>
>     $ make sparse >sp-out 2>&1 # nsp-out on 'next', psp-out on 'pu'
>
> ... so that I can diff the files from branch to branch. (I check the
> master branch file by hand. There is a single warning on Linux that
> is actually a sparse problem).
>
> Just FYI, for today's fetch:
>
>     $ diff sp-out nsp-out
>     $ diff nsp-out psp-out
>     12a13
>     >     SP blame.c
>     42a44,46
>     > diff.c:813:6: warning: symbol 'emit_line' was not declared. Should it be static?
>     > diff.c:828:6: warning: symbol 'emit_line_fmt' was not declared. Should it be static?
>     > diff.c:1865:6: warning: symbol 'print_stat_summary_0' was not declared. Should it be static?
>     54a59
>     >     SP fsmonitor.c
>     137a143
>     >     SP sub-process.c
>     170a177
>     >     SP compat/fopen.c
>     276a284
>     > builtin/worktree.c:539:38: warning: Using plain integer as NULL pointer
>     296a305
>     >     SP t/helper/test-dir-iterator.c
>     $ 

Interesting. One thing that I found somewhat suboptimal is that we do not get signalled by non-zero exit. Otherwise it would make a good addition to the "Static Analysis" task in .travis.yml file.

Previous: Ramsay JonesNext: Ramsay Jones
Message 7 of 9 in “usage: add NORETURN to BUG() function definitions”
  1. usage: add NORETURN to BUG() function definitionsRamsay Jones, May 21, 2017
  2. Junio C HamanoMay 22, 2017
  3. Ramsay JonesMay 22, 2017
  4. Junio C HamanoMay 22, 2017
  5. Junio C HamanoMay 22, 2017
  6. Ramsay JonesMay 22, 2017
  7. Junio C HamanoMay 23, 2017
  8. Ramsay JonesMay 23, 2017
  9. Jeff KingMay 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.