Re: [PATCH] usage: add NORETURN to BUG() function definitions

From: Junio C Hamano <gitster@pobox.com>
Date: May 22, 2017, 02:46 UTC
Message-ID: <xmqqd1b1pq1j.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqh90dpqja.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 19 quoted lines

> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> So, I don't know. Wait let me try your specific version:
>>
>> $ ~/sparse/sparse --version
>> v0.5.0-207-g14964df
>> $ ~/sparse/sparse usage.c
>> usage.c:220:6: error: symbol 'BUG_fl' redeclared with different type (originally declared at git-compat-util.h:1074) - different modifiers
>> $ 
>>
>> Er, dunno. (This is on Linux Mint 18.1).
>
> Oh, I don't question your expertise or competence.  There must be
> something I am doing wrong, and the version of sparse I happened to
> have run was the easiest thing to point a finger at, but that does
> not seem to be it.
>
> Thanks for helping.  I'll find time to dig deeper to find what's
> breaking it for me.

Hmph. I do not know what went wrong. The one I had in /usr/bin that came from the distro was too old that it didn't give any useful result and failed, and that was why I got v0.5.0-207-g14964df installed in ~/gitstuff/bin/ which is early on my $PATH; I do not think I did any other updates but now I am seeing happy results.

        $ git checkout jk/bug-to-abort^1
        $ make SP_OBJ=usage.sp sparse
        GIT_VERSION = 2.13.0.3.g25cd291963
            SP usage.c
        usage.c:220:6: error: symbol 'BUG_fl' redeclared with diff...

And then with your fix, of course,

        $ git checkout jk/bug-to-abort
        $ make SP_OBJ=usage.sp sparse
        GIT_VERSION = 2.13.0.4.g3d7dd2d3b6
            SP usage.c

I am still puzzled but anyway now the problem is clearly on my end and no longer reproduces, there is no reason to waste your time.

Sorry for the noise, and thanks for a fix again.