Re: [PATCH v1 2/2] log: add option to choose which refs to decorate
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 6, 2017, 03:51 UTC
- Message-ID
- <xmqqpo8whxot.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <9168f7b8-3b9d-a933-e542-ae5b741cb824@gmail.com>
Rafael Ascensão <rafa.almas@gmail.com> writes:
> Would checking the output of ref_exists() make sense here? > By that I mean, only add a trailing '/*' if the ref doesn't exist.
I do not think it would hurt, but it is not immediately obvious if the benefit of doing so outweighs the cost of having to make an extra call to ref_exists().