Re: [PATCH v1 1/2] refs: extract function to normalize partial refs

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Nov 6, 2017, 07:00 UTC
Message-ID: <1ae0c199-f0fe-4468-1481-c7217ef6cc11@alum.mit.edu>
In-Reply-To: <xmqqwp34jj3h.fsf@gitster.mtv.corp.google.com>

On 11/06/2017 02:23 AM, Junio C Hamano wrote:

Show 9 quoted lines

> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> [1] I say "almost entirely" because putting them in one function means
>> that only `pattern` needs to be scanned for glob characters. But that is
>> an unimportant detail.
> 
> That could actually be an important detail, in that even if prefix
> has wildcard, we'd still append the trailing "/*" as long as the
> pattern does not, right?

That's correct, but I was assuming that the prefix would always be a hard-coded string like "refs/tags/" or maybe "refs/". (That is the case now.) It doesn't seem very useful to use a prefix like "refs/*/".

Michael