git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/1] update-index doc: note a fixed bug in the untracked cache

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 27, 2017, 18:07 UTC
Message-ID
<xmqqpo70nixy.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171227112854.1322-1-avarab@gmail.com>
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
Show 21 quoted lines
> Document the bug tested for in my "status: add a failing test showing
> a core.untrackedCache bug" and fixed in Duy's "dir.c: fix missing dir
> invalidation in untracked code".
>
> Since this is very likely something others will encounter in the
> future on older versions, and it's not obvious how to fix it let's
> document both that it exists, and how to "fix" it with a one-off
> command.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>
>> On Tue, Dec 26, 2017 at 05:47:19PM +0700, Duy Nguyen wrote:
>>> Strangely, root dir is not cached (no valid flag). I don't know why
>>> but that's ok we'll roll with it.
>>
>> I figured this out. Which is good because now I know how/why the bug
>> happens.
>
> Thanks a lot. I think it's probably good to apply something like this
> on top of this now 3-patch series.

Thanks both for working well together. Now that the problem turns out not about symbolic links, can we update the test in 1/1 not to depend on symbolic links?

Show 25 quoted lines
>
>  Documentation/git-update-index.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt
> index bdb0342593..bc6c32002f 100644
> --- a/Documentation/git-update-index.txt
> +++ b/Documentation/git-update-index.txt
> @@ -464,6 +464,17 @@ command reads the index; while when `--[no-|force-]untracked-cache`
>  are used, the untracked cache is immediately added to or removed from
>  the index.
>  
> +Before 2.16, the untracked cache had a bug where replacing a directory
> +with a symlink to another directory could cause it to incorrectly show
> +files tracked by git as untracked. See the "status: add a failing test
> +showing a core.untrackedCache bug" commit to git.git. A workaround for
> +that was (and this might work for other undiscoverd bugs in the
> +future):
> +
> +----------------
> +$ git -c core.untrackedCache=false status
> +----------------
> +
>  File System Monitor
>  -------------------
Previous: Ævar Arnfjörð BjarmasonNext: Eric Sunshine
Message 7 of 12 in “status: add a failing test showing a core.untrackedCache bug”
  1. status: add a failing test showing a core.untrackedCache bugÆvar Arnfjörð Bjarmason, Dec 22, 2017
  2. Duy NguyenDec 25, 2017
  3. Ævar Arnfjörð BjarmasonDec 25, 2017
  4. Duy NguyenDec 26, 2017
  5. Duy NguyenDec 27, 2017
  6. 3/1 update-index doc: note a fixed bug in the untracked cacheÆvar Arnfjörð Bjarmason, Dec 27, 2017
  7. Junio C HamanoDec 27, 2017
  8. Eric SunshineDec 27, 2017
  9. Junio C HamanoDec 27, 2017
  10. Ævar Arnfjörð BjarmasonDec 27, 2017
  11. Duy NguyenDec 28, 2017
  12. Junio C HamanoDec 28, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.