Re: [PATCH v9 4/8] utf8: add function to detect a missing UTF-16/32 BOM

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 6, 2018, 23:37 UTC
Message-ID: <xmqqpo4g22tv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <EC8DF4D3-CDF5-4CEB-BD18-585341BBB2C5@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 5 quoted lines

> After thinking about it I wonder if we should barf on "utf16" without
> dash. Your Linux iconv would handle this correctly. My macOS iconv would not.
> That means the repo would checkout correctly on your machine but not on mine.
>
> What do you think?

To be bluntly honest, I prefer not to have excess "sanity checks"; there is no need to barf on utf16 in a project run by those who are without macOS friends, for example. For that matter, while I do not hate it so much to reject it, I am not all that supportive of this "The consortium says without -LE or -BE suffix there must be BOM, and this lacks one, so barf loudly" step in this topic myself.