Re: [PATCH v9 4/8] utf8: add function to detect a missing UTF-16/32 BOM

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 6, 2018, 23:07 UTC
Message-ID: <xmqq4lls3irx.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqq8tb43jfe.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> Lars Schneider <larsxschneider@gmail.com> writes:
>
>>>  Also "UTF16" or other spelling
>>> the platform may support but this code fails to recognise will go
>>> unchecked.
>>
>> That is true. However, I would assume all iconv implementations use the
>> same encoding names for UTF encodings, no? That means UTF16 would never be
>> valid. Would you agree?
>
> After seeing "UTF16" and others in "iconv -l | grep -i utf" output,
> I am not sure what you mean by "Would you agree?"  People can say in
> their .gitattributes file that this path is in "UTF16" without dash
> and that is what will be fed to this code, no?

FWIW, "iconv -f utf8 -t utf16" seems not to complain, so I am reasonably sure that people expect downcased ones to work as well.