git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] Resend of origin/sb/submodule-update-in-c

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 18, 2018, 22:24 UTC
Message-ID
<xmqqpnzki3mp.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180718194853.57994-1-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 24 quoted lines
> This fixes the compilation issue raised by SZEDER and Stolee,
>
>
> 6:  3c156c79ae7 ! 6:  f82f24e73b6 submodule--helper: introduce new update-module-mode helper
>     @@ -10,7 +10,6 @@
>          for arbitrary repositories.
>      
>          Signed-off-by: Stefan Beller <sbeller@google.com>
>     -    Signed-off-by: Junio C Hamano <gitster@pobox.com>
>      
>      diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
>      --- a/builtin/submodule--helper.c
>     @@ -74,7 +73,7 @@
>      +	determine_submodule_update_strategy(the_repository,
>      +					    just_cloned, path, update,
>      +					    &update_strategy);
>     -+	fprintf(stdout, submodule_strategy_to_string(&update_strategy));
>     ++	fputs(submodule_strategy_to_string(&update_strategy), stdout);
>      +
>      +	return 0;
>      +}
>
> Thanks,
> Stefan
Thanks.  

This time not from GGG? I don't particularly care which direction patches come from, though ;-)

Previous: Stefan BellerNext: Stefan Beller
Message 8 of 9 in “Resend of origin/sb/submodule-update-in-c”
  1. 0/6 Resend of origin/sb/submodule-update-in-cStefan Beller, Jul 18, 2018
  2. 1/6 git-submodule.sh: align error reporting for update mode to use pathStefan Beller, Jul 18, 2018
  3. 2/6 git-submodule.sh: rename unused variablesStefan Beller, Jul 18, 2018
  4. 3/6 builtin/submodule--helper: factor out submodule updatingStefan Beller, Jul 18, 2018
  5. 4/6 builtin/submodule--helper: store update_clone information in a structStefan Beller, Jul 18, 2018
  6. 5/6 builtin/submodule--helper: factor out method to update a single submoduleStefan Beller, Jul 18, 2018
  7. 6/6 submodule--helper: introduce new update-module-mode helperStefan Beller, Jul 18, 2018
  8. Junio C HamanoJul 18, 2018
  9. Stefan BellerJul 18, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.