Re: [PATCH 0/6] Resend of origin/sb/submodule-update-in-c

From: Stefan Beller <sbeller@google.com>
Date: Jul 18, 2018, 23:11 UTC
Message-ID: <CAGZ79kbYybZ8KbaECy2oqrTH9dUKVgTfrrxbOYWxhF14_d210A@mail.gmail.com>
In-Reply-To: <xmqqpnzki3mp.fsf@gitster-ct.c.googlers.com>

On Wed, Jul 18, 2018 at 3:24 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 31 quoted lines

>
> Stefan Beller <sbeller@google.com> writes:
>
> > This fixes the compilation issue raised by SZEDER and Stolee,
> >
> >
> > 6:  3c156c79ae7 ! 6:  f82f24e73b6 submodule--helper: introduce new update-module-mode helper
> >     @@ -10,7 +10,6 @@
> >          for arbitrary repositories.
> >
> >          Signed-off-by: Stefan Beller <sbeller@google.com>
> >     -    Signed-off-by: Junio C Hamano <gitster@pobox.com>
> >
> >      diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> >      --- a/builtin/submodule--helper.c
> >     @@ -74,7 +73,7 @@
> >      +        determine_submodule_update_strategy(the_repository,
> >      +                                            just_cloned, path, update,
> >      +                                            &update_strategy);
> >     -+        fprintf(stdout, submodule_strategy_to_string(&update_strategy));
> >     ++        fputs(submodule_strategy_to_string(&update_strategy), stdout);
> >      +
> >      +        return 0;
> >      +}
> >
> > Thanks,
> > Stefan
>
> Thanks.
>
> This time not from GGG?

GGG = GitGitGadget? I have yet to try out that tool, I am still stuck on git-send-email. (old habits die hard)

It is even based off your branch (with all your sign offs).

I just cut down aggressively on the range diff (and short stat), as I want to highlight the important part.

>  I don't particularly care which direction
> patches come from, though ;-)

Cool.

Thanks, Stefan