Re: [PATCH 3/7] submodule: is_submodule_active to differentiate between new and old mode

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2018, 21:39 UTC
Message-ID: <xmqqpnyb7627.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAGZ79kb-_7PTqe_9i4=FQQE7EmQsKN8+iB4snLetPD+r2UgpBQ@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 9 quoted lines

>> So I think this patch is insufficient, and needs to at least change
>> the "submodule.active" codepath to return !!ret; otherwise, a caller
>> that now expects 0 (not active), 1 (active but can lose URL) and 2
>> (active and the presence of URL makes it so) will be confused when
>> one of the MATCHED_* constants from dir.h comes back.
>
> Yes.
>
> I'll resend when appropriately.

Thanks.