git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 0/7] Unset the submodule URL in the superproject when no longer needed

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 16, 2018, 15:12 UTC
Message-ID
<xmqqd0uigxby.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180816023100.161626-1-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
Show 7 quoted lines
>   Originally we have had the url in the config, (a) that we can change
>   the URLs after the "git submodule init" and "git submodule update"
>   step that actually clones the submodule if not present and much more
>   importantly (b) to know which submodule "was initialized/active".
>   
>   Now that we have the submodule.active or even
>   submodule.<name>.active flags, we do not need (b) any more.
Up to that point the description is sane.
>   So the URL turns into a useless piece of cruft that just is unneeded
>   and might confuse the user.
>
> Opinions?

You spelled out why you do not need for (b) but not for (a) and worse it is is unclear if you never need it for (a) or under what condition you need it for (a). So there isn't enough information to form an opinion in the above. Sorry--readers need to go to the real patches.

Previous: Stefan BellerNext: Stefan Beller
Message 13 of 14 in “Unset the submodule URL in the superproject when no longer needed”
  1. 0/7 Unset the submodule URL in the superproject when no longer neededStefan Beller, Aug 16, 2018
  2. 1/7 t7410: update to new styleStefan Beller, Aug 16, 2018
  3. Junio C HamanoAug 16, 2018
  4. 2/7 builtin/submodule--helper: remove stray new lineStefan Beller, Aug 16, 2018
  5. 3/7 submodule: is_submodule_active to differentiate between new and old modeStefan Beller, Aug 16, 2018
  6. Junio C HamanoAug 16, 2018
  7. Stefan BellerAug 20, 2018
  8. Junio C HamanoAug 21, 2018
  9. 4/7 submodule sync: omit setting submodule URL in config if possibleStefan Beller, Aug 16, 2018
  10. 5/7 submodule--helper: factor out allocation of callback cookieStefan Beller, Aug 16, 2018
  11. 6/7 submodule--helper, update_clone: store index to update_clone instead of ceStefan Beller, Aug 16, 2018
  12. 7/7 builtin/submodule--helper: unset submodule url if possibleStefan Beller, Aug 16, 2018
  13. Junio C HamanoAug 16, 2018
  14. Stefan BellerAug 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.