Re: [PATCH v4 0/5] Show HTTP headers of failed requests with GIT_CURL_VERBOSE

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 10, 2019, 23:06 UTC
Message-ID: <xmqqpnt4yuwu.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190110193350.213327-1-masayasuzuki@google.com>

Masaya Suzuki <masayasuzuki@google.com> writes:

Show 6 quoted lines

> Diff from v3[1]:
>
> *   Handle ftruncate and fflush return values
> *   Call rewind to set the position back
>
> [1]: https://public-inbox.org/git/20190108024741.62176-1-masayasuzuki@google.com/

Thanks. Adding the error checking even to 1/5 and moving the updated code in 2/5 makes the range-diff a bit noisy, but the resulting series makes lot of sense.

Will queue.

Show 15 quoted lines

>
> Masaya Suzuki (5):
>   http: support file handles for HTTP_KEEP_ERROR
>   http: enable keep_error for HTTP requests
>   remote-curl: define struct for CURLOPT_WRITEFUNCTION
>   remote-curl: unset CURLOPT_FAILONERROR
>   test: test GIT_CURL_VERBOSE=1 shows an error
>
>  http.c                       | 32 +++++++++++++++++++-------------
>  http.h                       |  1 -
>  remote-curl.c                | 29 ++++++++++++++++++++++++-----
>  t/lib-httpd/apache.conf      |  1 +
>  t/t5581-http-curl-verbose.sh | 28 ++++++++++++++++++++++++++++
>  5 files changed, 72 insertions(+), 19 deletions(-)
>  create mode 100755 t/t5581-http-curl-verbose.sh