git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: reuse diff setup for --no-index case

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 24, 2019, 15:24 UTC
Message-ID
<xmqqpnrhmcpf.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190224094545.GA11538@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
>> Here's an attempt at that.  I did drop a few comments that seemed
>> pointless to me, as they're just re-stating the lines they describe.
>
> It looks like the original got merged to next. I think we at least need
> to deal with the "Otherwise..." comment, but I think the layout I posted
> in my followup is nicer overall. Was it a mistake to merge the first
> one?
>
> If so, do you want an incremental, or do you just want to drop it and
> redo as part of the post-2.21 rewind?

Will do a revert-and-replace just like I did for a few others I screwed up recently.

Thanks.
Previous: Jeff King
Message 6 of 6 in “External tool is ignored when using difftool with --no-index”
  1. Sylvain LacazeFeb 13, 2019
  2. diff: reuse diff setup for --no-index caseJeff King, Feb 13, 2019
  3. Junio C HamanoFeb 14, 2019
  4. Jeff KingFeb 16, 2019
  5. Jeff KingFeb 24, 2019
  6. Junio C HamanoFeb 24, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.