From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 24 Feb 2019 15:24:28 GMT
Subject: Re: [PATCH] diff: reuse diff setup for --no-index case
Message-ID: <xmqqpnrhmcpf.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190224094545.GA11538@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> Here's an attempt at that.  I did drop a few comments that seemed
>> pointless to me, as they're just re-stating the lines they describe.
>
> It looks like the original got merged to next. I think we at least need
> to deal with the "Otherwise..." comment, but I think the layout I posted
> in my followup is nicer overall. Was it a mistake to merge the first
> one?
>
> If so, do you want an incremental, or do you just want to drop it and
> redo as part of the post-2.21 rewind?

Will do a revert-and-replace just like I did for a few others I
screwed up recently.

Thanks.