git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] format-patch: generate valid patch with diff.noprefix config

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 2, 2020, 21:12 UTC
Message-ID
<xmqqpnahrx2y.fsf@gitster.c.googlers.com>
In-Reply-To
<20200602204924.GA1853335@spk-laptop>
Laurent Arnoud <laurent@spkdev.net> writes:
> With diff.noprefix enabled the patch generated with format-patch does not
> include prefix a/ and b/ so not applicable with `git am`.

Some projects (not this one) do not want to see a/ and b/ prefix in their patches, and noprefix is an option for those who needs to give patches to such projects. As "am" can be told with -p<num> to accept such a patch just fine, I do not think this change is appropriate.

> Solution is to force a_prefix and b_prefix on diffopt.
Sorry, I do not think there is any problem to be solved here ;-)
Previous: Laurent ArnoudNext: Laurent Arnoud
Message 2 of 7 in “format-patch: generate valid patch with diff.noprefix config”
  1. format-patch: generate valid patch with diff.noprefix configLaurent Arnoud, Jun 2, 2020
  2. Junio C HamanoJun 2, 2020
  3. Laurent ArnoudJun 2, 2020
  4. Junio C HamanoJun 2, 2020
  5. Laurent ArnoudJun 4, 2020
  6. Junio C HamanoJun 4, 2020
  7. Đoàn Trần Công DanhJun 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.