Re: [PATCH] format-patch: generate valid patch with diff.noprefix config

From: Laurent Arnoud <laurent@spkdev.net>
Date: Jun 4, 2020, 19:32 UTC
Message-ID: <20200604193238.GA1911544@spk-laptop>
In-Reply-To: <xmqqeeqxrufz.fsf@gitster.c.googlers.com>

On Tue, Jun 02, 2020 at 03:09:36PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> Having said all that, we seem to be letting more configurations for
> the diff.* family to affect the format-patch command.  The latest
> addition was "diff.relative"---together with the "diff.noprefix"
> that triggered this thread, some users may feel that it is a bug to
> allow these configuration variables to affect the output from the
> "log -p", "show", and "format-patch" commands.  
> 
> It *might* make sense to introduce log.diff.* configuration
> variables so that when they are set, they are used by
> log/show/format-patch instead of diff.* counterparts, or something
> along those lines.  I dunno.

I don't know if its a bug but I founded strange that I needed to use an alias "git -c diff.noprefix=false format-patch" to generate a patch that I can apply directly with "git am". I didn't know the -p option but to send a patch to a mailinglist it should have the prefix I guess ? I can try to implement this option if you think it can get merged

-- 
Laurent