Re: [PATCH] git-send-email: die if sendmail.* config is set

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 18, 2020, 18:02 UTC
Message-ID: <xmqqpn8sbt0w.fsf@gitster.c.googlers.com>
In-Reply-To: <20200718132311.27248-1-sir@cmpwn.com>

Drew DeVault <sir@cmpwn.com> writes:

> I've seen several people mis-configure git send-email on their first
> attempt because they set the sendmail.* config options - not
> sendemail.*. This patch detects this mistake and bails out with a
> friendly warning.

It is not very friendly thing to do, though.

It just closes the door for anybody to add something that works independent from "git send-email", to which "sendmail.*" variables may be appropriate knob to use.

Demoting the "die" to "warn" is OK, and limiting the check to variables that actually has corresponding and likely-misspelt "sendemail.*" counterparts would be even better, but "you are not allowed to have any 'sendmail.*' variables, ever" is way too much, I am afraid.

Show 19 quoted lines

> Signed-off-by: Drew DeVault <sir@cmpwn.com>
> ---
>  git-send-email.perl |  6 ++++++
>  perl/Git.pm         | 26 ++++++++++++++++++++++++++
>  2 files changed, 32 insertions(+)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 36c47bae1d..8e42ba00c1 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -478,6 +478,12 @@ sub read_config {
>      usage();
>  }
>  
> +if ((scalar Git::config_regexp("sendmail.*")) != 0) {
> +	die __("fatal: found configuration options for 'sendmail'\n" .
> +		"git-send-email is configured with the sendemail.* options - note the 'e'.\n" .
> +		"Assuming this is a mistake and bailing out.\n");
> +}