Re: [PATCH] git-send-email: die if sendmail.* config is set

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 18, 2020, 20:10 UTC
Message-ID: <xmqqh7u4bn4d.fsf@gitster.c.googlers.com>
In-Reply-To: <C49YLQZUZ4RG.129ZY8FQEYDYU@homura>

"Drew DeVault" <sir@cmpwn.com> writes:

Show 5 quoted lines

> I originally had this just a warning, but it can be difficult to see.
> There's a lot of text printed from git send-email, a lot of it looks
> like diagnostics, and it can be easy to lose a message in there. And if
> you pass --annotate, which I encourage people to do, your editor
> immediately covers up the warning.

OK.

> I wonder if a happy medium would be adding a config option which
> squelches the message? If sendemail.squelchConfigError is set, for
> example.

I think with "squelches the message" replaced with "bypasses the check", it would probably be a good idea. It may be that a reasonable behaviour would be to check for any "sendemail.*" and die, like your version does, by default, an optional opt-out configuration variable (sendemail.forbidSendmailVariables) to disable the check entirely, and then add a hint that mentions the variable to the "die" message in your patch.