Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 20, 2020, 01:59 UTC
Message-ID: <xmqqpn5dd5dv.fsf@gitster.c.googlers.com>
In-Reply-To: <20201020001103.GB2774782@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 11 quoted lines

> On Mon, Oct 19, 2020 at 04:26:07AM +0000, Joey S wrote:
>> 
>> Hi everyone,
> Hi Joey and welcome.
>
>> 
>> Signed-off-by: JoeyS <jgsal@yahoo.com>
>
> One thing missed by other commenters: the Developer's Certificate of
> Origin line - which is what this indicates - should have your "full
> name".

... and it must match the authorship.

> So in my case, I sign my patches 'Emily Shaffer
> <emilyshaffer@google.com>'. If I'm wrong that's fine, but JoeyS sounds
> like a name and initial rather than a full name.

Thanks for pointing it out.

If somebody from the "mentoring" group is taking a tally, it might not be a bad idea to identify which style and procedure rules are often failed to be followed by new contributors so that we can figure out ways to make them stand out in our documentation set (e.g. Documentation/SubmittingPatches but maybe a separate cheat sheet might be worth having).

Thanks.