git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [OUTREACHY][PATCH v1] t7006: Use test_path_is_* functions in test script

From
Emily Shaffer <emilyshaffer@google.com>
Date
Oct 20, 2020, 00:11 UTC
Message-ID
<20201020001103.GB2774782@google.com>
In-Reply-To
<ERmIkC3rLZ3BAyv2Nq_GK0CjWvEQw6ejl8V-HVvwCsyIv0guQV67nO8KMLi7eA9qO5mo_ZJ8XB360uP_LtP-LY1xsaRBXHsc0F1uSID-KPE=@protonmail.com>
On Mon, Oct 19, 2020 at 04:26:07AM +0000, Joey S wrote:
> 
> Hi everyone,
Hi Joey and welcome.
> 
> Signed-off-by: JoeyS <jgsal@yahoo.com>

One thing missed by other commenters: the Developer's Certificate of Origin line - which is what this indicates - should have your "full name". So in my case, I sign my patches 'Emily Shaffer <emilyshaffer@google.com>'. If I'm wrong that's fine, but JoeyS sounds like a name and initial rather than a full name.

The rest of the patch looks okay to me, though.
 - Emily
Previous: Taylor BlauNext: Junio C Hamano
Message 4 of 8 in “t7006: Use test_path_is_* functions in test script”
  1. Joey SOct 19, 2020
  2. Phillip WoodOct 19, 2020
  3. Taylor BlauOct 19, 2020
  4. Emily ShafferOct 20, 2020
  5. Junio C HamanoOct 20, 2020
  6. Joey SOct 20, 2020
  7. Phillip WoodOct 20, 2020
  8. Joey SOct 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.