Re: [PATCH 2/7] diffcore-rename: remove unnecessary if-clause

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 10, 2020, 06:56 UTC
Message-ID: <xmqqpn3iw3n0.fsf@gitster.c.googlers.com>
In-Reply-To: <CABPp-BFcSV_LPy-_AW+c-1OgzAyHfEM7D+YL+fFwxYKDheqxEg@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

> Ah, so would you be okay replacing these with
>
>    if (st_mult(num_targets, limited_sources) <= st_mult(rename_limit,
> rename_limit))

It's subtle that the use of size_t is a sensible thing to do, and definitely deserves an in-line comment, but I think that is a good way to go.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.