Re: [PATCH v3] ci: disallow directional formatting

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 4, 2021, 17:19 UTC
Message-ID: <xmqqpmrf3kjz.fsf@gitster.g>
In-Reply-To: <211104.86ee7whvoz.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 8 quoted lines

>> +# U+202a..U+2a2e: LRE, RLE, PDF, LRO and RLO
>> +# U+2066..U+2069: LRI, RLI, FSI and PDI
>> +regex='(\u202a|\u202b|\u202c|\u202d|\u202e|\u2066|\u2067|\u2068|\u2069)'
>> +
>> +! LC_CTYPE=C git grep -El "$(LC_CTYPE=C.UTF-8 printf "$regex")" \
>> +	-- ':(exclude,attr:binary)' ':(exclude)*.po'
> ...
>    ! git -P grep -nP '[\N{U+202a}-\N{U+202e}\N{U+2066}-\N{U+2069}]' ':!(attr:binary)'

So you are comparing

 * requiring bash and C.UTF-8 locale to be available

vs

 * requiring git built with PCRE

assuming that "Dscho says doesn't work with PCRE and you say it works with PCRE" is resolved? They seem roughly the same difficulty to me.