Re: [PATCH v2] ci: disallow directional formatting

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 3, 2021, 23:38 UTC
Message-ID: <xmqqk0ho4xo5.fsf@gitster.g>
In-Reply-To: <pull.1071.v2.git.1635942236065.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> +# U+202a..U+2a2e: LRE, RLE, PDF, LRO and RLO
> +# U+2066..U+2069: LRI, RLI, FSI and PDI
> +regex='(\u202a|\u202b|\u202c|\u202d|\u202e|\u2066|\u2067|\u2068|\u2069)'
> +
> +! git ls-files -z ':(attr:!binary)' |
> +LC_CTYPE=C xargs -0r git grep -Ele "$(LC_CTYPE=C.UTF-8 printf "$regex")" --

One thing for the future, and one thing for the present.

 - Do some languages we would add to po/ hierarchy in the future
   possibly want to use these sequences as legitimate contents?

 - Do we need ls-files?

For the latter, shouldn't the attribute-based pathspec work just fine with "git grep"? i.e.

    git grep -l -E -e $pattern -- ':(exclude,attr:binary)'