Re: [PATCH v4 1/2] sequencer: don't use die_errno() on refs_resolve_ref_unsafe() failure

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2022, 23:57 UTC
Message-ID: <xmqqpmoenj85.fsf@gitster.g>
In-Reply-To: <patch-v4-1.2-7f31277fd57-20220126T143427Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 8 quoted lines

> Change code that was faithfully migrated to the new "resolve_errno"
> API in ed90f04155d (refs API: make resolve_ref_unsafe() not set errno,
> 2021-10-16) to stop caring about the errno at all.
>
> When we fail to resolve "HEAD" after the sequencer runs it doesn't
> really help to say what the "errno" value is, since the fake backend
> errno may or may not reflect anything real about the state of the
> ".git/HEAD".

OK. Assuming that the eventual goal is to drop the return value parameter from the resolve_ref_unsafe() function (because according to this caller, it is not yielding any meaningful value), this change makes perfect sense.

> With the upcoming reftable backend this fakery will
> become even more pronounced.

This too.

Nicely explained and executed.

Thanks.