errno oversight

From

Han-Wen Nienhuys <hanwen@google.com>

Date

Dec 8, 2021, 11:38 UTC

Message-ID

<CAFQ2z_NHXKss4LVBAFVpE7LFXt2OeOz9P9wi-z8riwHXWDb28w@mail.gmail.com>

In refs.c in origin/next and origin/seen, we have the following fragment:

                   if (refs_read_raw_ref(refs, refname, oid, &sb_refname,
                                      &read_flags, failure_errno)) {
                        *flags |= read_flags;
                        if (errno)
                                *failure_errno = errno;

overwriting failure_errno looks like an oversight?

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado