Re: [PATCH] gc: use temporary file for editing crontab

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 24, 2022, 16:06 UTC
Message-ID: <xmqqpmgp8w2x.fsf@gitster.g>
In-Reply-To: <YwVDcO/V+zx2iy4I@tapette.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 10 quoted lines

>> There is something wrong with this patch: it needs to update
>> t/helper/test-crontab.c in order to pass t7900-maintenance.sh.
>
> Will fix.
>
>> While the memory release is nice, I also think it would be good to use
>> delete_tempfile() so the temporary file is deleted within this method,
>> not waiting until the end of the process to do that cleanup.
>
> Sounds good.  I'll include that in a v2.

Thanks for following through the idea fell out of earlier discussion. I almost forgot about it, and it is very good to see it written and reviewed quickly like this.

Thanks, all.