git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git maintenance broken on FreeBSD

From
Derrick Stolee <derrickstolee@github.com>
Date
Aug 15, 2022, 13:22 UTC
Message-ID
<1dd29f43-1a8e-eb69-3320-7f5140a0e18e@github.com>
In-Reply-To
<Yvfg7WwL8oCdxqzQ@tapette.crustytoothpaste.net>
On 8/13/2022 1:35 PM, brian m. carlson wrote:
Show 27 quoted lines
> On 2022-08-13 at 17:26:05, Junio C Hamano wrote:
>> Does FreeBSD offer choices of cron implementations other than Vixie,
>> just like some Linux distributions?  If somebody on a non-FreeBSD
>> platform happens to choose to use Vixie, then they would presumably
>> have the same problem, so a compile-time switch, whose default is
>> hardcoded based on the target platform, would not work very well.
>> The default will be wrong for some users, and users can later choose
>> to switch between different cron implementations.
> 
> I'm using Debian unstable, and I'm using Vixie cron.  I believe that's
> the default implementation.  However, I could also well use cronie,
> since that's available in Debian as well.  So, yeah, I think this is a
> thing to consider.
> 
>> Configuration knob can be used as a workaround, but in this case, I
>> am not sure if it is worth doing.  What's the downside of securely
>> opening a temporary file and write whatever we are currently piping
>> to a spawned "crontab" command and then giving the path to that
>> temporary file to the "crontab" command?  Wouldn't that give us the
>> maximal portability without that much code, no?
> 
> I think we should try to provide an option which works across at least
> the versions on a particular OS.  The temporary file seems like a nice,
> portable option, so I think we should just do that unless there's some
> practical objection.
> 
> If Derrick doesn't get to it this next week, I can send a patch.

I agree that the tempfile approach makes the most sense in terms of what we can do within the Git codebase.

I won't be able to get to this change this week, so I'd be happy to review one of yours, brian. Be careful to test manually when making this change, because our tests don't actually interact with the system's crontab and instead verify the interaction using replacement commands.

Thanks, -Stolee

Previous: brian m. carlsonNext: Junio C Hamano
Message 8 of 19 in “git maintenance broken on FreeBSD”
  1. Renato BotelhoAug 12, 2022
  2. Đoàn Trần Công DanhAug 12, 2022
  3. Todd ZullingerAug 13, 2022
  4. Junio C HamanoAug 13, 2022
  5. Đoàn Trần Công DanhAug 13, 2022
  6. Junio C HamanoAug 13, 2022
  7. brian m. carlsonAug 13, 2022
  8. Derrick StoleeAug 15, 2022
  9. Junio C HamanoAug 15, 2022
  10. gc: use temporary file for editing crontabbrian m. carlson, Aug 23, 2022
  11. Johannes SchindelinAug 23, 2022
  12. Derrick StoleeAug 23, 2022
  13. brian m. carlsonAug 23, 2022
  14. Junio C HamanoAug 24, 2022
  15. gc: use temporary file for editing crontabbrian m. carlson, Aug 28, 2022
  16. Junio C HamanoAug 29, 2022
  17. Renato BotelhoAug 29, 2022
  18. Derrick StoleeAug 30, 2022
  19. test-crontab: minor memory and error handling fixesJeff King, Aug 30, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.