Re: [PATCH] imap-send: replace auto-probe libcurl with hard dependency

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 2, 2023, 01:32 UTC
Message-ID: <xmqqpmasx35s.fsf@gitster.g>
In-Reply-To: <230202.86zg9xormj.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 13 quoted lines

> The equivalent of USE_CURL_FOR_IMAP_SEND is now always true, and that's
> what "--curl" would enable.
>
> The "--no-curl" option would then have us use the OpenSSL codepath, but
> that'll no longer be supported, we'll always use curl.
> ...
>> Or did you just forget to document that we stop to ship with our own
>> IMAP routines in the above?  If so, as long as it is made a bit more
>> prominent in the proposed log message in a reroll, I would be happy
>> with such a change rolled into the same patch.
>
> I'm not sure what you mean here, we still ship with the same routines,
> we just always take the "curl" codepath for the non-tunnel codepath now.

I am referring to this part of the documentation:

    --no-curl::
            Talk to the IMAP server using git's own IMAP routines instead of
            using libcurl.  Ignored if Git was built with the NO_OPENSSL option
            set.

So when built with openssl and libcURL, we used to have a feature that allowed to bypass cURL by passing --no-curl for whatever reason the user chooses to avoid cURL. This patch discards that option, doesn't it?

Maybe such an optional feature may not be very useful, but it should be explained and defended in the proposed log message, and it also sounds like an orthogonal change to always require libcURL.