git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t2015-checkout-unborn.sh: changes the style for cd

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 21, 2023, 20:01 UTC
Message-ID
<xmqqpma2eqjs.fsf@gitster.g>
In-Reply-To
<20230218192128.7963-1-ashutosh.pandeyhlr007@gmail.com>
ashutosh.pandeyhlr007@gmail.com writes:
Show 38 quoted lines
> From: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
>
> the `cd` followed the old style which wasn't consistent with the rest of
> the test suite, so this commit makes it consistent with the current
> style of the test suite for `cd` in  subshell.
>
> Signed-off-by: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
> ---
> this is my first time contributing to git I want to participate in 
> this year's GSoC and I'm looking for some microprojects the ones
> that are listed on the website are mostly done so if anyone can 
> suggest some beginners level microprojects that would be great.
>
>  t/t2015-checkout-unborn.sh | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/t/t2015-checkout-unborn.sh b/t/t2015-checkout-unborn.sh
> index 9425aae639..fdc4149f15 100755
> --- a/t/t2015-checkout-unborn.sh
> +++ b/t/t2015-checkout-unborn.sh
> @@ -9,11 +9,12 @@ TEST_PASSES_SANITIZE_LEAK=true
>  
>  test_expect_success 'setup' '
>  	mkdir parent &&
> -	(cd parent &&
> -	 git init &&
> -	 echo content >file &&
> -	 git add file &&
> -	 git commit -m base
> +	(
> +		cd parent &&
> +	 	git init &&
> +	 	echo content >file &&
> +	 	git add file &&
> +	 	git commit -m base
>  	) &&
>  	git fetch parent main:origin
>  '

OK. This makes it siimlar to the last test in the same t2015 script that uses this "more recent" style.

Looks good.
Thanks.
Previous: ashutosh.pandeyhlr007@gmail.comNext: Junio C Hamano
Message 2 of 3 in “t2015-checkout-unborn.sh: changes the style for cd”
  1. t2015-checkout-unborn.sh: changes the style for cdashutosh.pandeyhlr007@gmail.com, Feb 18, 2023
  2. Junio C HamanoFeb 21, 2023
  3. Junio C HamanoFeb 21, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.