threads / patch / 59268

patcht2015-checkout-unborn.sh: changes the style for cd

Subject: [PATCH] t2015-checkout-unborn.sh: changes the style for cd

## tl;dr

3 messages between Feb 18, 2023 and Feb 21, 2023. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

ashutosh.pandeyhlr007@gmail.com· Feb 18, 2023, 19:21 UTC · lore
From: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>

the `cd` followed the old style which wasn't consistent with the rest of the test suite, so this commit makes it consistent with the current style of the test suite for `cd` in subshell.

Signed-off-by: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
---
this is my first time contributing to git I want to participate in 
this year's GSoC and I'm looking for some microprojects the ones
that are listed on the website are mostly done so if anyone can 
suggest some beginners level microprojects that would be great.
 t/t2015-checkout-unborn.sh | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Show changes to t/t2015-checkout-unborn.sh +6 −5
diff --git a/t/t2015-checkout-unborn.sh b/t/t2015-checkout-unborn.sh
index 9425aae639..fdc4149f15 100755
--- a/t/t2015-checkout-unborn.sh
+++ b/t/t2015-checkout-unborn.sh
@@ -9,11 +9,12 @@ TEST_PASSES_SANITIZE_LEAK=true
 
 test_expect_success 'setup' '
 	mkdir parent &&
-	(cd parent &&
-	 git init &&
-	 echo content >file &&
-	 git add file &&
-	 git commit -m base
+	(
+		cd parent &&
+	 	git init &&
+	 	echo content >file &&
+	 	git add file &&
+	 	git commit -m base
 	) &&
 	git fetch parent main:origin
 '

base-commit: d9d677b2d8cc5f70499db04e633ba7a400f64cbf
-- 
2.39.2
Junio C Hamano· Feb 21, 2023, 20:01 UTC · re: ashutosh.pandeyhlr007@gmail.com · lore

Re: [PATCH] t2015-checkout-unborn.sh: changes the style for cd

ashutosh.pandeyhlr007@gmail.com writes:
Show 38 quoted lines
> From: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
>
> the `cd` followed the old style which wasn't consistent with the rest of
> the test suite, so this commit makes it consistent with the current
> style of the test suite for `cd` in  subshell.
>
> Signed-off-by: Ashutosh Pandey <ashutosh.pandeyhlr007@gmail.com>
> ---
> this is my first time contributing to git I want to participate in 
> this year's GSoC and I'm looking for some microprojects the ones
> that are listed on the website are mostly done so if anyone can 
> suggest some beginners level microprojects that would be great.
>
>  t/t2015-checkout-unborn.sh | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/t/t2015-checkout-unborn.sh b/t/t2015-checkout-unborn.sh
> index 9425aae639..fdc4149f15 100755
> --- a/t/t2015-checkout-unborn.sh
> +++ b/t/t2015-checkout-unborn.sh
> @@ -9,11 +9,12 @@ TEST_PASSES_SANITIZE_LEAK=true
>  
>  test_expect_success 'setup' '
>  	mkdir parent &&
> -	(cd parent &&
> -	 git init &&
> -	 echo content >file &&
> -	 git add file &&
> -	 git commit -m base
> +	(
> +		cd parent &&
> +	 	git init &&
> +	 	echo content >file &&
> +	 	git add file &&
> +	 	git commit -m base
>  	) &&
>  	git fetch parent main:origin
>  '

OK. This makes it siimlar to the last test in the same t2015 script that uses this "more recent" style.

Looks good.
Thanks.
Junio C Hamano· Feb 21, 2023, 20:04 UTC · re: ashutosh.pandeyhlr007@gmail.com · lore

Re: [PATCH] t2015-checkout-unborn.sh: changes the style for cd

ashutosh.pandeyhlr007@gmail.com writes:
Show 6 quoted lines
> +	(
> +		cd parent &&
> +	 	git init &&
> +	 	echo content >file &&
> +	 	git add file &&
> +	 	git commit -m base

These four lines begin with "HT SP HT"; the space between the horizontal tabs should be removed.

No need to resend, as "git am --whitespace=fix" already corrected them.

Thanks.

← back to recent threads