Re: [PATCH v2 5/6] tests: remove duplicate .gitmodules path

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2023, 23:35 UTC
Message-ID: <xmqqpm9tpdmw.fsf@gitster.g>
In-Reply-To: <20230228185642.2357806-5-calvinwan@google.com>

Calvin Wan <calvinwan@google.com> writes:

Show 5 quoted lines

> Swapping `git add <submodule>` to `git submodule add <submodule>`
> in a previous patch created a .gitmodules file with multiple
> submodules pointing to the same path in certain tests. Fix tests
> so that they are run on the original added submodule rather than
> a separate manually configured submodule.

Doesn't "git submodule add" have a way to give a specific name other than the default taken from the path? If "git add sub" is converted to "git submodule add --name subname ./sub", wouldn't these changes become unnecessary?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.